Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): use canonical_chain on range lookups #11332

Merged
merged 6 commits into from
Oct 1, 2024
Merged

fix(provider): use canonical_chain on range lookups #11332

merged 6 commits into from
Oct 1, 2024

Conversation

joshieDo
Copy link
Collaborator

alternative to #10068

closes #10037

may close #11053 #11308

  • use canonical_chain on fetch_db_mem_range_while to lookup in-mem range atomically
  • takes priority of in-mem blocks on overlaps

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-db Related to the database labels Sep 30, 2024
@github-actions github-actions bot added the C-enhancement New feature or request label Sep 30, 2024
@joshieDo joshieDo mentioned this pull request Sep 30, 2024
Closed
@joshieDo joshieDo marked this pull request as draft September 30, 2024 11:23
@joshieDo joshieDo marked this pull request as ready for review September 30, 2024 12:23
This was referenced Sep 30, 2024
Merged
Merged
@joshieDo joshieDo added A-blockchain-tree Related to sidechains, reorgs and pending blocks and removed C-enhancement New feature or request labels Sep 30, 2024
@Rjected Rjected mentioned this pull request Sep 30, 2024
Open
@mattsse mattsse mentioned this pull request Oct 1, 2024
Merged
@joshieDo joshieDo requested a review from fgimenez October 1, 2024 11:46
fgimenez
fgimenez approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshieDo joshieDo added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit b29d81c Oct 1, 2024
35 checks passed
@joshieDo joshieDo deleted the joshie/inmem-iter branch October 1, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@fgimenez fgimenez fgimenez approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
3 participants
@joshieDo @fgimenez @mattsse